| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Andy Fan <zhihui(dot)fan1213(at)gmail(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Add "-Wimplicit-fallthrough" to default flags |
| Date: | 2020-05-13 15:34:21 |
| Message-ID: | 2472.1589384061@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
>> I fear that is going to mean that we revert this patch.
> Or we can filter-out the -Wimplicit-fallthrough, or change to level 3,
> for bison-emitted files.
Let's just go to level 3 overall (and revert the changes you made for
level 4 compliance --- they're more likely to cause back-patching
pain than do anything useful).
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2020-05-13 16:04:40 | Re: Add "-Wimplicit-fallthrough" to default flags |
| Previous Message | Alvaro Herrera | 2020-05-13 15:23:57 | Re: Add "-Wimplicit-fallthrough" to default flags |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2020-05-13 15:38:15 | Re: SLRU statistics |
| Previous Message | Jehan-Guillaume de Rorthais | 2020-05-13 15:29:18 | Re: Is it possible to find out write_lsn on standby? |