| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Andy Fan <zhihui(dot)fan1213(at)gmail(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Add "-Wimplicit-fallthrough" to default flags |
| Date: | 2020-05-13 15:23:57 |
| Message-ID: | 20200513152357.GA5411@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On 2020-May-13, Tom Lane wrote:
> Andy Fan <zhihui(dot)fan1213(at)gmail(dot)com> writes:
> >> FWIW, I got a warning for jsonpath_gram.c.
>
> Ugh. Confirmed here on Fedora 30 (bison 3.0.5).
Ugh.
> > I just found this just serval minutes ago. Upgrading your bison to the
> > latest version (3.6) is ok. I'd like we have a better way to share this
> > knowledge through. I spend ~30 minutes to troubleshooting this issue.
>
> I fear that is going to mean that we revert this patch.
Or we can filter-out the -Wimplicit-fallthrough, or change to level 3,
for bison-emitted files.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2020-05-13 15:34:21 | Re: Add "-Wimplicit-fallthrough" to default flags |
| Previous Message | Tom Lane | 2020-05-13 14:02:34 | Re: Add "-Wimplicit-fallthrough" to default flags |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2020-05-13 15:28:40 | Re: Do I understand commit timestamps correctly? |
| Previous Message | Tomas Vondra | 2020-05-13 15:23:39 | Re: SLRU statistics |