| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Christoph Berg <cb(at)df7cb(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: includedir_internal headers are not self-contained |
| Date: | 2014-04-28 18:50:09 |
| Message-ID: | 24633.1398711009@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Mon, Apr 28, 2014 at 1:20 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> It's more verbose, it's not actually any more information, and in many
>> cases it's actively misleading, because what's printed is NOT the real
>> file name --- it omits segment numbers for instance. As a particularly
>> egregious example, in xact_desc_commit() we print a pathname including
>> MAIN_FORKNUM, which is a flat out lie to the reader, because what will
>> actually get deleted is all forks.
> Yeah, technically it's a lie, but ls <copy-and-paste-here>* is pretty
> handy. If you format it some other way it's annoying to reformat it.
Handy for what? How often do you need to do that? (And if you do do it,
how often will you remember that the filename is only approximate?)
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2014-04-28 18:51:15 | Re: includedir_internal headers are not self-contained |
| Previous Message | Peter Geoghegan | 2014-04-28 18:49:36 | Re: Clock sweep not caching enough B-Tree leaf pages? |