| From: | Andres Freund <andres(at)2ndquadrant(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Christoph Berg <cb(at)df7cb(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: includedir_internal headers are not self-contained |
| Date: | 2014-04-28 18:51:15 |
| Message-ID: | 20140428185115.GG14464@awork2.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2014-04-28 14:44:16 -0400, Robert Haas wrote:
> > BTW, for the same reasons I'm less than impressed with the uses of
> > relpath in error messages in, eg, reorderbuffer.c:
> >
> > relation = RelationIdGetRelation(reloid);
> >
> > if (relation == NULL)
> > elog(ERROR, "could open relation descriptor %s",
> > relpathperm(change->data.tp.relnode, MAIN_FORKNUM));
> >
> > Printing anything other than the relation OID here is irrelevant,
> > misleading, and inconsistent with our practice everywhere else.
> > Let's not even mention the missing "not" in the message text.
>
> Uggh.
I'll send a fix once I am home (~3h).
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2014-04-28 19:02:48 | Re: includedir_internal headers are not self-contained |
| Previous Message | Tom Lane | 2014-04-28 18:50:09 | Re: includedir_internal headers are not self-contained |