Re: pgsql: Move Assert() definitions to c.h

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Move Assert() definitions to c.h
Date: 2013-02-01 22:28:00
Message-ID: 24603.1359757680@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> Move Assert() definitions to c.h

This seems a bit odd. Why didn't you move all of postgres.h's section 3
into the new section in c.h? The couple of declarations you left there
are neither useful nor intelligible on their own.

Also, I think there's a typo here:

+#else /* USE_ASSERT_CHECKING && FRONTEND */

Should be

+#else /* USE_ASSERT_CHECKING && !FRONTEND */

no?

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2013-02-01 22:44:42 Re: pgsql: Move Assert() definitions to c.h
Previous Message Alvaro Herrera 2013-02-01 21:32:24 pgsql: Move Assert() definitions to c.h