Re: pgsql: Move Assert() definitions to c.h

Tom Lane wrote:
> Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> > Move Assert() definitions to c.h
>
> This seems a bit odd. Why didn't you move all of postgres.h's section 3
> into the new section in c.h? The couple of declarations you left there
> are neither useful nor intelligible on their own.

Hmm, true, I didn't consider that. Will fix.

> Also, I think there's a typo here:
>
> +#else /* USE_ASSERT_CHECKING && FRONTEND */
>
> Should be
>
> +#else /* USE_ASSERT_CHECKING && !FRONTEND */
>
> no?

This bit I did consider. It wasn't clear to me whether those comments
mean that the condition spelled out in the comment holds for the lines
below, or that they hold for the lines above. Note the comment after
the #endif holds for the lines above it.

After searching for precedent, I found one in ip.c and it seems to
support what you say.

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services