Re: Spinlock can be released twice in procsignal.c

From: Andrey Borodin <x4mmm(at)yandex-team(dot)ru>
To: Maxim Orlov <orlovmg(at)gmail(dot)com>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, "Maksim(dot)Melnikov" <m(dot)melnikov(at)postgrespro(dot)ru>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Jelte Fennema-Nio <postgres(at)jeltef(dot)nl>
Subject: Re: Spinlock can be released twice in procsignal.c
Date: 2025-02-26 08:25:49
Message-ID: 2437220C-F2FC-4A08-BD12-6444552EC98C@yandex-team.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Michael, thanks a lot for the detailed explanation.

> On 26 Feb 2025, at 11:57, Maxim Orlov <orlovmg(at)gmail(dot)com> wrote:
>
> Indeed. PFA the correct one.
>
> <v2-0001-Avoid-double-spinlock-release.patch>

I’d suggest to give some more descriptive name to “logit” and expand comment “/* sanity check */“. This comment was easier to understand when elog() was near, but now IMO we can have few words about what is going on.

Best regards, Andrey Borodin.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jakub Wartak 2025-02-26 08:38:20 Re: Draft for basic NUMA observability
Previous Message Jacob Brazeal 2025-02-26 07:59:15 Re: Experimental tool to explore commitfest patches