From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | "Jaime Casanova" <systemguards(at)gmail(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: [COMMITTERS] pgsql: Add GUC temp_tablespaces to provide a default location for |
Date: | 2007-03-05 22:45:08 |
Message-ID: | 23755.1173134708@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers pgsql-patches |
momjian(at)postgresql(dot)org (Bruce Momjian) writes:
> Add GUC temp_tablespaces to provide a default location for temporary
> objects.
> Jaime Casanova
I hadn't looked at this patch before, but now that I have, it is
rather broken.
In the first place, it makes no provision for RemovePgTempFiles() to
clean up leftover temp files that are in non-default places.
In the second place, it's a serious violation of what little modularity
and layering we have for fd.c to be calling into commands/tablespace.c.
This is not merely cosmetic but has real consequences: one being that
it's now unsafe to call OpenTemporaryFile outside a transaction.
Please revert until the submitter can come up with a better-designed
patch.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2007-03-05 23:29:14 | pgsql: Remove copied comments from geo_ops.c source file and replace |
Previous Message | User Okbob | 2007-03-05 21:33:33 | plpsm - plpgpsm: now can run on 8.1. |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2007-03-05 23:05:57 | Re: proposal: custom variables management |
Previous Message | Jeff Davis | 2007-03-05 22:43:02 | Re: Bug: Buffer cache is not scan resistant |
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2007-03-05 23:34:53 | Re: [HACKERS] [CORE] GPL Source and Copyright Questions |
Previous Message | Mike Rylander | 2007-03-05 22:18:51 | xml2 contrib patch supporting default XML namespaces |