From: | Bruce Momjian <bruce(at)momjian(dot)us> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Jaime Casanova <systemguards(at)gmail(dot)com>, Albert Cervera Areny <albertca(at)hotpop(dot)com>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org> |
Subject: | Re: [HACKERS] [COMMITTERS] pgsql: Add GUC temp_tablespaces to provide a default location for |
Date: | 2007-03-06 02:08:54 |
Message-ID: | 200703060208.l2628sl08031@momjian.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers pgsql-patches |
OK, patch reverted. Authors, would you please resubmit with fixes?
Thanks.
---------------------------------------------------------------------------
Tom Lane wrote:
> momjian(at)postgresql(dot)org (Bruce Momjian) writes:
> > Add GUC temp_tablespaces to provide a default location for temporary
> > objects.
> > Jaime Casanova
>
> I hadn't looked at this patch before, but now that I have, it is
> rather broken.
>
> In the first place, it makes no provision for RemovePgTempFiles() to
> clean up leftover temp files that are in non-default places.
>
> In the second place, it's a serious violation of what little modularity
> and layering we have for fd.c to be calling into commands/tablespace.c.
> This is not merely cosmetic but has real consequences: one being that
> it's now unsafe to call OpenTemporaryFile outside a transaction.
>
> Please revert until the submitter can come up with a better-designed
> patch.
>
> regards, tom lane
>
> ---------------------------(end of broadcast)---------------------------
> TIP 4: Have you searched our list archives?
>
> http://archives.postgresql.org
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://www.enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
Attachment | Content-Type | Size |
---|---|---|
/rtmp/diff | text/x-diff | 15.2 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2007-03-06 09:54:23 | pgsql: Add more information about avoiding Linux OOM killer. |
Previous Message | Bruce Momjian | 2007-03-06 02:06:15 | pgsql: Revert temp_tablespaces because of coding problems, per Tom. |
From | Date | Subject | |
---|---|---|---|
Next Message | Marc G. Fournier | 2007-03-06 02:32:29 | Re: [PATCHES] |
Previous Message | Luke Lonergan | 2007-03-06 01:42:30 | Re: Bug: Buffer cache is not scan resistant |
From | Date | Subject | |
---|---|---|---|
Next Message | Marc G. Fournier | 2007-03-06 02:32:29 | Re: [PATCHES] |
Previous Message | Bruce Momjian | 2007-03-05 23:34:53 | Re: [HACKERS] [CORE] GPL Source and Copyright Questions |