snpe <snpe(at)snpe(dot)co(dot)yu> writes:
> + // handle autocommit=false in postgresql.conf
> + if (haveMinimumServerVersion("7.3")) {
> + ExecSQL("set autocommit to on; commit;");
> + }
The above will fill people's logs with
WARNING: COMMIT: no transaction in progress
if they don't have autocommit off.
Use
begin; set autocommit to on; commit;
instead.
I would recommend holding off on this patch altogether, actually,
until we decide whether SET will be a transaction-initiating
command or not. I would still like to persuade the hackers community
that it should not be.
regards, tom lane