| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Piotr Stefaniak <postgres(at)piotr-stefaniak(dot)me> |
| Cc: | Bruce Momjian <bruce(at)momjian(dot)us>, Andres Freund <andres(at)anarazel(dot)de>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, "Stephen Frost" <sfrost(at)snowman(dot)net>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Preliminary results for proposed new pgindent implementation |
| Date: | 2017-06-17 02:18:07 |
| Message-ID: | 23382.1497665887@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Piotr Stefaniak <postgres(at)piotr-stefaniak(dot)me> writes:
> On 2017-06-17 00:02, Tom Lane wrote:
>> What I'm testing with right now has just four differences from your repo:
> There are also the "portability fixes" and they're the main problem.
Fair enough.
> I've simply removed things like capsicum or __FBSDID() because I thought
> it wouldn't be a problem since Postgres will have its own copy of indent
> anyway (so that its behavior is not a moving target). I can ifdef-out
> them instead of removing entirely, I just didn't think it was important
> anymore.
We should be able to deal with those via some #define hackery, no?
> I expect to be in trouble for replacing err() and errx(), though.
Understood. I think we could deal with this by providing err() and
errx() in a support file that would be part of our distribution but
not yours.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ashutosh Sharma | 2017-06-17 02:43:26 | Re: Getting server crash on Windows when using ICU collation |
| Previous Message | David G. Johnston | 2017-06-17 01:58:43 | Re: how are the rpms configured that are available in PostgreSQL RPM Building Project - Yum Repository |