From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Bruce Momjian <bruce(at)momjian(dot)us> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: [COMMITTERS] pgsql: Add PGFILEDESC description to Makefiles for all /contrib |
Date: | 2010-05-12 17:44:07 |
Message-ID: | 22912.1273686247@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
Bruce Momjian <bruce(at)momjian(dot)us> writes:
> Tom Lane wrote:
>> momjian(at)postgresql(dot)org (Bruce Momjian) writes:
>>> Add PGAPPICON to all executable makefiles.
>>
>> Is it really a good idea to have done that to the server, in particular?
>> I can't imagine it being a good idea to launch the postmaster from a
>> GUI, which is what I suppose this is good for.
> Well, I assume this was the "icon", which I assumed should match for all
> the binaries, as compared to config files, for example.
Er... why are you committing undiscussed patches if you just "assume"
they will work, or indeed do anything useful at all? You should not
have touched this if you don't know exactly what it will do and why
changing it is a good thing.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Simon Riggs | 2010-05-12 19:45:02 | pgsql: Give most recovery conflict errors a retryable error code. |
Previous Message | Bruce Momjian | 2010-05-12 17:38:50 | Re: [COMMITTERS] pgsql: Add PGFILEDESC description to Makefiles for all /contrib |
From | Date | Subject | |
---|---|---|---|
Next Message | Joshua D. Drake | 2010-05-12 17:50:26 | Re: primary/secondary/master/slave/standby |
Previous Message | Bruce Momjian | 2010-05-12 17:38:50 | Re: [COMMITTERS] pgsql: Add PGFILEDESC description to Makefiles for all /contrib |