Re: [COMMITTERS] pgsql: Add PGFILEDESC description to Makefiles for all /contrib

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [COMMITTERS] pgsql: Add PGFILEDESC description to Makefiles for all /contrib
Date: 2010-05-12 19:52:26
Message-ID: 201005121952.o4CJqQv26583@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > Tom Lane wrote:
> >> momjian(at)postgresql(dot)org (Bruce Momjian) writes:
> >>> Add PGAPPICON to all executable makefiles.
> >>
> >> Is it really a good idea to have done that to the server, in particular?
> >> I can't imagine it being a good idea to launch the postmaster from a
> >> GUI, which is what I suppose this is good for.
>
> > Well, I assume this was the "icon", which I assumed should match for all
> > the binaries, as compared to config files, for example.
>
> Er... why are you committing undiscussed patches if you just "assume"
> they will work, or indeed do anything useful at all? You should not
> have touched this if you don't know exactly what it will do and why
> changing it is a good thing.

All other binaries had such a designation, and all /contrib binaries
were missing them. I assume I was doing cleanup. You want the icon
removed from the backend makefile? I can easily do it.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2010-05-12 19:59:40 Re: [COMMITTERS] pgsql: Add PGFILEDESC description to Makefiles for all /contrib
Previous Message Simon Riggs 2010-05-12 19:45:02 pgsql: Give most recovery conflict errors a retryable error code.

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2010-05-12 19:55:19 Re: max_standby_delay considered harmful
Previous Message Andrew Dunstan 2010-05-12 19:52:07 Re: Tags missing from GIT mirror?