Re: Re: [COMMITTERS] pgsql: Change the way that LWLocks for extensions are allocated.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Re: [COMMITTERS] pgsql: Change the way that LWLocks for extensions are allocated.
Date: 2016-11-12 16:42:12
Message-ID: 22899.1478968932@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Andres Freund <andres(at)anarazel(dot)de> writes:
> On 2016-11-12 11:30:42 -0500, Tom Lane wrote:
>> which is a rather blatant waste of cycles. I would suggest an explicit
>> do-nothing installcheck rule rather than the hack you came up with here.

> I had that at first, but that generates a warning about overwriting the
> makefile target - which afaics cannot be fixed.

Hm. What about inventing an additional macro NO_INSTALLCHECK that
prevents pgxs.mk from generating an installcheck rule? It's not
like we don't have similar issues elsewhere, eg contrib/sepgsql.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2016-11-12 17:12:25 Re: Re: [COMMITTERS] pgsql: Change the way that LWLocks for extensions are allocated.
Previous Message Andres Freund 2016-11-12 16:35:08 Re: Re: [COMMITTERS] pgsql: Change the way that LWLocks for extensions are allocated.

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2016-11-12 17:12:25 Re: Re: [COMMITTERS] pgsql: Change the way that LWLocks for extensions are allocated.
Previous Message Andres Freund 2016-11-12 16:35:08 Re: Re: [COMMITTERS] pgsql: Change the way that LWLocks for extensions are allocated.