| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Re: [COMMITTERS] pgsql: Change the way that LWLocks for extensions are allocated. |
| Date: | 2016-11-12 17:12:25 |
| Message-ID: | 20161112171225.eo5vm7cjfatufm6q@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On 2016-11-12 11:42:12 -0500, Tom Lane wrote:
> Andres Freund <andres(at)anarazel(dot)de> writes:
> > On 2016-11-12 11:30:42 -0500, Tom Lane wrote:
> >> which is a rather blatant waste of cycles. I would suggest an explicit
> >> do-nothing installcheck rule rather than the hack you came up with here.
>
> > I had that at first, but that generates a warning about overwriting the
> > makefile target - which afaics cannot be fixed.
>
> Hm. What about inventing an additional macro NO_INSTALLCHECK that
> prevents pgxs.mk from generating an installcheck rule?
That'd work. I'd also be ok with living with the warning. I have to say
I find it hard to be concerned about the cycles here. It's not like
anybody complained about make check unconditionally creating a test
installation, even if there's tests in a contrib module...
Andres
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2016-11-12 17:17:10 | Re: Re: [COMMITTERS] pgsql: Change the way that LWLocks for extensions are allocated. |
| Previous Message | Tom Lane | 2016-11-12 16:42:12 | Re: Re: [COMMITTERS] pgsql: Change the way that LWLocks for extensions are allocated. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2016-11-12 17:17:10 | Re: Re: [COMMITTERS] pgsql: Change the way that LWLocks for extensions are allocated. |
| Previous Message | Tom Lane | 2016-11-12 16:42:12 | Re: Re: [COMMITTERS] pgsql: Change the way that LWLocks for extensions are allocated. |