Re: [PATCH] Tab complete EXECUTE FUNCTION for CREATE (EVENT) TRIGGER

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>, David Fetter <david(at)fetter(dot)org>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH] Tab complete EXECUTE FUNCTION for CREATE (EVENT) TRIGGER
Date: 2018-10-25 11:52:01
Message-ID: 22671.1540468321@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Michael Paquier <michael(at)paquier(dot)xyz> writes:
> To keep the code simple, you could do something like that, by checking
> the head keywords for a match with CREATE TRIGGER, and then move all the
> existing conditions within it:
> ...
> char *execute_keyword;
> ...
> blah and use execute_keyword in the lists;

Don't think that works unless we remove some of the "const" annotation
in COMPLETE_WITH; which I'd rather not.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Sandeep Thakkar 2018-10-25 11:53:02 Re: Problem with EDB 11.0 Windows x64 distributions
Previous Message Michael Paquier 2018-10-25 11:49:30 Re: pg_stat_replication vs StandbyReplyMessage