Re: [PATCH] Tab complete EXECUTE FUNCTION for CREATE (EVENT) TRIGGER

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>, David Fetter <david(at)fetter(dot)org>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH] Tab complete EXECUTE FUNCTION for CREATE (EVENT) TRIGGER
Date: 2018-10-25 09:16:50
Message-ID: 22338.1540459010@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Michael Paquier <michael(at)paquier(dot)xyz> writes:
> On Wed, Oct 24, 2018 at 10:36:41AM +0100, Dagfinn Ilmari Mannsåker wrote:
>> Fair point. I was unsure about whether to complete every supported
>> variant or just the new one. Updated patches attached.

> One problem with this approach is that a user needs to use twice tab.
> The first time is to show "EXECUTE", and the second time is to show
> automatically "PROCEDURE" or "FUNCTION" automatically.

Yeah. Why don't we keep the existing behavior of completing both
words at once, but make it server-version-dependent which completion
you get?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Matsumura, Ryo 2018-10-25 09:33:12 RE: [PROPOSAL]a new data type 'bytea' for ECPG
Previous Message Jehan-Guillaume de Rorthais 2018-10-25 09:15:51 Re: Using old master as new replica after clean switchover