From: | "Wetmore, Matthew (CTR)" <Matthew(dot)Wetmore(at)evernorth(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Francisco Olarte <folarte(at)peoplecall(dot)com>, Michael Bondarenko <work(dot)michael(dot)2956(at)gmail(dot)com>, "pgsql-bugs(at)lists(dot)postgresql(dot)org" <pgsql-bugs(at)lists(dot)postgresql(dot)org>, "dgrowleyml(at)gmail(dot)com" <dgrowleyml(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
Subject: | BUG #18348: Inconsistency with EXTRACT([field] from INTERVAL); |
Date: | 2024-05-07 22:09:34 |
Message-ID: | 2219fd69a3024149af5adc31e14b25d7@evernorth.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs pgsql-hackers |
Devils advocating here, feel free to ignore.
Is there a real need for a negative month? Sounds like high level this could be disastrous if I screw up the syntax. (Ah, memories of DD)
I have done this in data warehousing with dimensions tables.
Just process on the INT and translate into the name.
I was thinking on how a negative month could impact this side (data warehousing) side of querying.
I could be chicken little on this, but wanted it in the conversation.
workaround for negative months:
CREATE TABLE dim_biz_hours( year INT(4)
, doy INT(3)
, dow INT(7)
, month INT(2)
, day INT(2)
, hour INT(2)
, minute INT(2)
, second INT(2)
, utc_offset INT(2)
, utc_offset_dst INT(2)
);
INSERT INTO biz_hours (year)
SELECT * FROM generate_series(2000, 2099);
INSERT INTO biz_hours (doy)
SELECT * FROM generate_series(1, 366);
INSERT INTO biz_hours (dow)
SELECT * FROM generate_series(1, 7);
INSERT INTO biz_hours (month)
SELECT * FROM generate_series(1, 12);
INSERT INTO biz_hours (day)
SELECT * FROM generate_series(1, 31) ;
INSERT INTO biz_hours (hour)
SELECT * FROM generate_series(1, 24);
INSERT INTO biz_hours (minute)
SELECT * FROM generate_series(1, 60);
INSERT INTO biz_hours (second
SELECT * FROM generate_series(1, 60);
INSERT INTO biz_hours (utc_offset)
SELECT * FROM generate_series(1, 24);
INSERT INTO biz_hours (utc_offset_dst)
SELECT * FROM generate_series(1, 24);
-----Original Message-----
From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Sent: Tuesday, May 7, 2024 2:27 PM
To: jian he <jian(dot)universality(at)gmail(dot)com>
Cc: Francisco Olarte <folarte(at)peoplecall(dot)com>; Michael Bondarenko <work(dot)michael(dot)2956(at)gmail(dot)com>; pgsql-bugs(at)lists(dot)postgresql(dot)org; dgrowleyml(at)gmail(dot)com; Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
Subject: [EXTERNAL] Re: BUG #18348: Inconsistency with EXTRACT([field] from INTERVAL);
jian he <jian(dot)universality(at)gmail(dot)com> writes:
> On Wed, Feb 21, 2024 at 4:56 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> Yeah, I see what you mean: the output for negative month counts is
>>> very bizarre, whereas other fields seem to all produce the negative
>>> of what they'd produce for the absolute value of the interval.
>>> We could either try to fix that or decide that rejecting "quarter"
>>> for intervals is the saner answer.
>> After fooling with these cases for a little I'm inclined to think we
>> should do it as attached (no test or docs changes yet).
> ... I don't know how to write the documentation for the `quarter` when
> it's negative.
After poking at it some more, I realized that my draft patch was still wrong about that. We really have to look at interval->month if we want to behave plausibly for negative months.
Here's a more fleshed-out patch. I don't think we really need to document the behavior for negative intervals; at least, we haven't done that so far for any other fields. I did add testing of such cases though.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | jian he | 2024-05-08 01:03:56 | Re: BUG #18348: Inconsistency with EXTRACT([field] from INTERVAL); |
Previous Message | Tom Lane | 2024-05-07 21:27:08 | Re: BUG #18348: Inconsistency with EXTRACT([field] from INTERVAL); |
From | Date | Subject | |
---|---|---|---|
Next Message | David Rowley | 2024-05-07 22:35:42 | Re: Revert: Remove useless self-joins *and* -DREALLOCATE_BITMAPSETS make server crash, regress test fail. |
Previous Message | Noah Misch | 2024-05-07 22:00:23 | Re: Weird test mixup |