| From: | Noah Misch <noah(at)leadboat(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Weird test mixup |
| Date: | 2024-05-07 22:00:23 |
| Message-ID: | 20240507220023.47.nmisch@google.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, May 07, 2024 at 11:53:10AM -0700, Noah Misch wrote:
> On Tue, May 07, 2024 at 10:17:49AM +0900, Michael Paquier wrote:
> > Overall, this switches from one detach behavior to a different one,
>
> Can you say more about that? The only behavior change known to me is that a
> given injection point workload uses more of INJ_MAX_CONDITION. If there's
> another behavior change, it was likely unintended.
I see patch inplace030-inj-exit-race-v1.patch does not fix the race seen with
repro-inj-exit-race-v1.patch. I withdraw inplace030-inj-exit-race-v1.patch,
and I withdraw the above question.
> To reproduce, apply [repro-inj-exit-race-v1.patch] to add
> sleeps, and run:
>
> make -C src/test/modules/gin installcheck USE_MODULE_DB=1 & sleep 2; make -C contrib/intarray installcheck USE_MODULE_DB=1
>
> Separately, I see injection_points_attach() populates InjectionPointCondition
> after InjectionPointAttach(). Shouldn't InjectionPointAttach() come last, to
> avoid the same sort of race? I've not tried to reproduce that one.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Wetmore, Matthew (CTR) | 2024-05-07 22:09:34 | BUG #18348: Inconsistency with EXTRACT([field] from INTERVAL); |
| Previous Message | Tom Lane | 2024-05-07 21:27:08 | Re: BUG #18348: Inconsistency with EXTRACT([field] from INTERVAL); |