Re: Why we don't have checksums on clog files

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Alex Ignatov <a(dot)ignatov(at)postgrespro(dot)ru>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Why we don't have checksums on clog files
Date: 2016-06-13 02:54:54
Message-ID: 21784.1465786494@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Tue, Jun 7, 2016 at 10:41 AM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>> I think it will be better if users can have an option to checksum clog
>> pages. However, I think that will need a change in page (CLOG-page) format
>> which might not be a trivial work to accomplish.

> Doesn't the pd_checksum field exist on SLRU pages also?

Uh, no.

(I don't think that's an inherent property of slru.c, but definitely
clog.c packs the pages totally fully of xact status bits. See
CLOG_XACTS_PER_PAGE.)

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2016-06-13 03:39:31 ERROR: ORDER/GROUP BY expression not found in targetlist
Previous Message Robert Haas 2016-06-13 02:28:33 Re: Why we don't have checksums on clog files