| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
| Cc: | Andres Freund <andres(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: btree_gist macaddr valgrind woes |
| Date: | 2014-05-16 19:31:52 |
| Message-ID: | 21358.1400268712@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> writes:
> On 05/16/2014 06:43 PM, Tom Lane wrote:
>> Dunno what's the problem for the varlena types, but that's a completely
>> separate code path.
> It seems to be a similar issue to what I fixed in the bit type earlier.
> When the lower+upper keys are stored as one varlen Datum, the padding
> bytes between them are not zeroed. With these datatypes (i.e. not
> varbit) it doesn't lead to any real errors, however, because the padding
> bytes are never read. Valgrind is just complaining that we're storing
> uninitialized data on disk, even though it's never looked at.
Yeah, I came to the same conclusions.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2014-05-16 19:36:29 | Re: btree_gist macaddr valgrind woes |
| Previous Message | Heikki Linnakangas | 2014-05-16 19:30:10 | Re: btree_gist macaddr valgrind woes |