From: | Andres Freund <andres(at)2ndquadrant(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: btree_gist macaddr valgrind woes |
Date: | 2014-05-16 19:44:20 |
Message-ID: | 20140516194420.GB13967@awork2.anarazel.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi,
On 2014-05-16 15:31:52 -0400, Tom Lane wrote:
> Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> writes:
> > On 05/16/2014 06:43 PM, Tom Lane wrote:
> >> Dunno what's the problem for the varlena types, but that's a completely
> >> separate code path.
>
> > It seems to be a similar issue to what I fixed in the bit type earlier.
> > When the lower+upper keys are stored as one varlen Datum, the padding
> > bytes between them are not zeroed. With these datatypes (i.e. not
> > varbit) it doesn't lead to any real errors, however, because the padding
> > bytes are never read. Valgrind is just complaining that we're storing
> > uninitialized data on disk, even though it's never looked at.
>
> Yeah, I came to the same conclusions.
Thanks for fixing, looks good here.
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2014-05-16 19:44:53 | Re: %d in log_line_prefix doesn't work for bg/autovacuum workers |
Previous Message | Heikki Linnakangas | 2014-05-16 19:39:26 | Re: Re: pg_basebackup: could not get transaction log end position from server: FATAL: could not open file "./pg_hba.conf~": Permission denied |