Re: BUG #11032: Prepared transactions do not update pg_last_xact_replay_timestamp() anymore

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)2ndquadrant(dot)com>
Cc: s(dot)zuban(at)gmail(dot)com, pgsql-bugs(at)postgresql(dot)org, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>
Subject: Re: BUG #11032: Prepared transactions do not update pg_last_xact_replay_timestamp() anymore
Date: 2014-07-24 22:32:09
Message-ID: 21266.1406241129@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

Andres Freund <andres(at)2ndquadrant(dot)com> writes:
> On 2014-07-24 17:46:13 -0400, Tom Lane wrote:
>> It looks to me like this never worked: the code around recoveryStopsHere
>> has never paid any attention to COMMIT_PREPARED (or ABORT_PREPARED).

> I wonder if this is possibly influenced by
> bb38fb0d43c8d7ff54072bfd8bd63154e536b384. IIRC before it committing a
> prepared xact caused a plain commit record for the xid doing the COMMIT
> PREPARED.

Hm, I see nothing in that commit that looks like it would've changed
what gets written to WAL (and if it did, we have a serious minor version
compatibility issue). OTOH, if it did, that would explain the
complaint of a behavioral change since the last minor releases.

regards, tom lane

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Andres Freund 2014-07-24 22:34:59 Re: BUG #11032: Prepared transactions do not update pg_last_xact_replay_timestamp() anymore
Previous Message Andres Freund 2014-07-24 21:57:43 Re: BUG #11032: Prepared transactions do not update pg_last_xact_replay_timestamp() anymore