| From: | Andres Freund <andres(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | s(dot)zuban(at)gmail(dot)com, pgsql-bugs(at)postgresql(dot)org |
| Subject: | Re: BUG #11032: Prepared transactions do not update pg_last_xact_replay_timestamp() anymore |
| Date: | 2014-07-24 21:57:43 |
| Message-ID: | 20140724215743.GG16857@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On 2014-07-24 17:46:13 -0400, Tom Lane wrote:
> s(dot)zuban(at)gmail(dot)com writes:
> > After upgrade from 9.3.4 to 9.3.5 pg_last_xact_replay_timestamp() returns
> > outdated timestamp.
>
> > It stopped working properly after commit
> > d19bd29f07aef9e508ff047d128a4046cc8bc1e2
>
> Really?
>
> It looks to me like this never worked: the code around recoveryStopsHere
> has never paid any attention to COMMIT_PREPARED (or ABORT_PREPARED).
> Certainly that patch had zip to do with the replay-timestamp behavior.
>
> If you think it worked before, I'd like to see what your test case was.
I wonder if this is possibly influenced by
bb38fb0d43c8d7ff54072bfd8bd63154e536b384. IIRC before it committing a
prepared xact caused a plain commit record for the xid doing the COMMIT
PREPARED.
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2014-07-24 22:32:09 | Re: BUG #11032: Prepared transactions do not update pg_last_xact_replay_timestamp() anymore |
| Previous Message | Tom Lane | 2014-07-24 21:46:13 | Re: BUG #11032: Prepared transactions do not update pg_last_xact_replay_timestamp() anymore |