Re: [UNVERIFIED SENDER] pg_upgrade can result in early wraparound on databases with high transaction load

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, "Drouvot, Bertrand" <bdrouvot(at)amazon(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, Jason Harvey <jason(at)reddit(dot)com>, Peter Geoghegan <pg(at)bowt(dot)ie>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, "Tharakan, Robins" <tharar(at)amazon(dot)com>
Subject: Re: [UNVERIFIED SENDER] pg_upgrade can result in early wraparound on databases with high transaction load
Date: 2024-05-16 17:47:37
Message-ID: 2122064.1715881657@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general pgsql-hackers

Daniel Gustafsson <daniel(at)yesql(dot)se> writes:
>> On 5 Jul 2022, at 18:59, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Given the lack of field complaints, it's probably not worth trying
>> to do anything to restore that capability. But we really ought to
>> update pg_upgrade's code and docs in pre-v15 branches to say that
>> the minimum supported source version is 9.0.

> (reviving an old thread from the TODO)

> Since we never got around to doing this we still refer to 8.4 as a possible
> upgrade path in v14 and older.

Oh, yeah, that seems to have fallen through a crack.

> The attached takes the conservative approach of raising the minimum supported
> version to 9.0 while leaving the code to handle 8.4 in place. While it can be
> removed, the risk/reward tradeoff of gutting code in backbranches doesn't seem
> appealing since the code will be unreachable with this check anyways.

Yeah, it's not worth working harder than this. I do see one typo
in your comment: s/supported then/supported when/. LGTM otherwise.

regards, tom lane

In response to

Responses

Browse pgsql-general by date

  From Date Subject
Next Message Benjamin Mitchell 2024-05-17 06:59:07 Do we have any email discussions related to SQL rate limiting?
Previous Message Adrian Klaver 2024-05-16 16:13:29 Re: Restore of a reference database kills the auto analyze processing.

Browse pgsql-hackers by date

  From Date Subject
Next Message Jeff Davis 2024-05-16 18:26:08 Re: Statistics Import and Export
Previous Message Jacob Burroughs 2024-05-16 17:39:04 Re: Add new protocol message to change GUCs for usage with future protocol-only GUCs