| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Abhijit Menon-Sen <ams(at)2ndQuadrant(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Robert Haas <robertmhaas(at)gmail(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Christoph Berg <myon(at)debian(dot)org>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: fsync-pgdata-on-recovery tries to write to more files than previously |
| Date: | 2015-05-28 03:41:29 |
| Message-ID: | 20950.1432784489@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Abhijit Menon-Sen <ams(at)2ndQuadrant(dot)com> writes:
> At 2015-05-27 20:22:18 -0400, tgl(at)sss(dot)pgh(dot)pa(dot)us wrote:
>> I doubt that that (not using AllocateDir) []
> (Disregarding per your followup.)
>> What I think is a reasonable compromise is to treat AllocateDir
>> failure as nonfatal, but to continue using ReadDir etc which means
>> that any post-open failure in reading a successfully-opened directory
>> would be fatal.
> OK, that's halfway between the two patches I posted. Will do.
Thought you were disregarding?
Anyway, I had an idea about reducing the ugliness. What you basically
did is copy-and-paste ReadDir so you could change the elevel. What
about turning ReadDir into a wrapper around a ReadDirExtended function
that adds an elevel argument?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Abhijit Menon-Sen | 2015-05-28 03:57:59 | Re: fsync-pgdata-on-recovery tries to write to more files than previously |
| Previous Message | Robert Haas | 2015-05-28 03:08:58 | Re: About that re-release ... |