| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | Charles Duffy <charles(dot)duffy(at)gmail(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org, Qingqing Zhou <zhouqq(at)cs(dot)toronto(dot)edu>, pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: [HACKERS] putting CHECK_FOR_INTERRUPTS in |
| Date: | 2006-07-29 23:05:13 |
| Message-ID: | 20568.1154214313@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Bruce Momjian <bruce(at)momjian(dot)us> writes:
> Are we done with the sort interrupt issue mentioned in the subject line,
> and the issue outlined below?
I'm inclined not to apply the proposed patch (adding
CHECK_FOR_INTERRUPTS) because of the risk of memory leakage inside
qsort. OTOH you could argue that there's an unfixable risk of memory
leakage there anyway, because it's always possible that the invoked
datatype comparison routine exits with elog(ERROR) for some reason,
or even contains a CHECK_FOR_INTERRUPTS call itself. Comments?
As for the question of whether we should try to detoast sort keys before
sorting, I'd suggest adding that to TODO. Investigating whether this
would be a good idea will take more time than we have for 8.2, so it's
gonna have to wait for a future cycle.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2006-07-29 23:30:42 | Re: Do we need multiple forms of the SQL2003 statistics |
| Previous Message | Tom Lane | 2006-07-29 22:38:12 | Re: [HACKERS] pg_regress breaks on msys |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Greg Sabino Mullane | 2006-07-30 01:14:16 | New variable server_version_num |
| Previous Message | Tom Lane | 2006-07-29 22:38:12 | Re: [HACKERS] pg_regress breaks on msys |