From: | Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | Gurjeet Singh <gurjeet(at)singh(dot)im>, Postgres Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: lwlocknames.h beautification attempt |
Date: | 2025-03-17 06:43:41 |
Message-ID: | 202503170643.pqbsgi4ly5bs@alvherre.pgsql |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2025-Mar-16, Robert Haas wrote:
> On Fri, Mar 14, 2025 at 3:38 PM Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
> > I forgot to send a note here that I pushed this patch. Thank you.
>
> I'm confused. Tom and I both said we didn't like this change, so you
> committed the patch without further discussion?
Tom didn't say he didn't like this change. He said he didn't like a
different change, which is not the one I committed. And your opinion
was quite thin on arguments, and you didn't reply for 11 days after I
expressed intention to apply a simplified version of Gurjeet's patch.
> I mean, this is a pretty unimportant detail, so I don't really want to
> fight about it too much, but that really doesn't seem like a consensus
> to me.
Would you have objected if I had proposed to use that style to begin with?
You can see that the thread where this was discussed [1] was pretty
light on coding style/output style discussion. It seems hard to argue
that the original had achieved any kind of consensus.
[1] https://postgr.es/m/202401231025.gbv4nnte5fmm@alvherre.pgsql
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
From | Date | Subject | |
---|---|---|---|
Next Message | Gurjeet Singh | 2025-03-17 06:44:07 | Fwd: lwlocknames.h beautification attempt |
Previous Message | vignesh C | 2025-03-17 06:42:48 | Re: Vacuum statistics |