From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Bruce Momjian <bruce(at)momjian(dot)us> |
Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: pg_dump and schema names |
Date: | 2013-08-09 16:53:20 |
Message-ID: | 20250.1376067200@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Bruce Momjian <bruce(at)momjian(dot)us> writes:
> On Fri, Aug 9, 2013 at 01:48:43AM -0400, Tom Lane wrote:
>> The practical difficulties involved can be seen by reading the comments
>> and code for _getObjectDescription().
> Yes, I looked at that. Seems _getObjectDescription() is only called
> from _printTocEntry(), and that function has a call to
> _selectOutputSchema() at the top, so we already know we have search_path
> set to the proper schema.
> The attached patch removes the unnecessary schema qualification for
> ALTER OWNER, and the attached dump file show a two-schema dump that
> restores just fine.
This really requires more than no attention to the comments, especially
since you just removed the only apparent reason for _getObjectDescription
to make a distinction between objects whose name includes a schema and
those that don't.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Craig Ringer | 2013-08-09 16:57:14 | Re: confusing error message |
Previous Message | Tom Lane | 2013-08-09 16:48:50 | Re: question about HTTP API |