| From: | Sutou Kouhei <kou(at)clear-code(dot)com> |
|---|---|
| To: | michael(at)paquier(dot)xyz |
| Cc: | andres(at)anarazel(dot)de, tgl(at)sss(dot)pgh(dot)pa(dot)us, pgsql-hackers(at)postgresql(dot)org, ishii(at)sraoss(dot)co(dot)jp |
| Subject: | Re: confusing / inefficient "need_transcoding" handling in copy |
| Date: | 2024-12-16 02:39:58 |
| Message-ID: | 20241216.113958.1744811828797567834.kou@clear-code.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
In <Z1-PjE6KPimF8w55(at)paquier(dot)xyz>
"Re: confusing / inefficient "need_transcoding" handling in copy" on Mon, 16 Dec 2024 11:25:16 +0900,
Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> On Sat, Dec 14, 2024 at 04:46:57PM +0900, Michael Paquier wrote:
>> Note that using "test" as table name for the tests is not a good idea,
>> as this could very likely conflict with some concurrent activity. I
>> would also add two RESET queries to remove the dependency to
>> client_encoding once the test has no need to rely on it. No need to
>> send a new patch for all that, just noticing in passing.
>
> I got some time to look again at this one. Applied with the tweaks
> for the table name and the two RESET queries.
Thanks!
I'll use better table name next time.
Thanks,
--
kou
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2024-12-16 02:58:51 | Re: strangely worded message |
| Previous Message | Michael Paquier | 2024-12-16 02:25:16 | Re: confusing / inefficient "need_transcoding" handling in copy |