| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Kirill Reshke <reshkekirill(at)gmail(dot)com> |
| Cc: | jian he <jian(dot)universality(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: attndims, typndims still not enforced, but make the value within a sane threshold |
| Date: | 2024-12-05 14:43:08 |
| Message-ID: | 202412051443.honqx6sa5nz3@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2024-Dec-05, Kirill Reshke wrote:
> On Fri, 20 Sept 2024 at 07:11, jian he <jian(dot)universality(at)gmail(dot)com> wrote:
> > attached patch removes attndims and typndims entirely.
>
> LGTM?
> I see no open items in this thread. Are there any issues about v1?
Should we leave TupleDescInitEntry()'s API alone, to avoid breaking the
compilation of every extension in the world? Maybe we could rename the
function (say to TupleDescInitializeEntry()) and use a define?
#define TupleDescInitEntry(a,b,c,d,e,f) TupleDescInitializeEntry(a,b,c,d,e)
Then the amount of churn is reduced, no extensions are broken, and we
can remove the define in a few years.
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
"Debido a que la velocidad de la luz es mucho mayor que la del sonido,
algunas personas nos parecen brillantes un minuto antes
de escuchar las pelotudeces que dicen." (Roberto Fontanarrosa)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2024-12-05 14:59:54 | Re: Proposal to add a new URL data type. |
| Previous Message | Yugo NAGATA | 2024-12-05 14:16:01 | Re: EphemeralNamedRelation and materialized view |