Re: Make COPY format extendable: Extract COPY TO format implementations

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
Cc: Sutou Kouhei <kou(at)clear-code(dot)com>, michael(at)paquier(dot)xyz, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Make COPY format extendable: Extract COPY TO format implementations
Date: 2024-11-21 10:41:18
Message-ID: 202411211041.v25vlwo2uvjr@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I ran `make headerscheck` after these patches and it reported a few
problems:

/pgsql/source/master/src/tools/pginclude/headerscheck /pgsql/source/master /pgsql/build/master
In file included from /tmp/headerscheck.xdG40Y/test.c:2:
/pgsql/source/master/src/include/commands/copyapi.h:76:44: error: unknown type name ‘CopyFromState’; did you mean ‘CopyToState’?
76 | void (*CopyFromInFunc) (CopyFromState cstate, Oid atttypid,
| ^~~~~~~~~~~~~
| CopyToState
/pgsql/source/master/src/include/commands/copyapi.h:87:43: error: unknown type name ‘CopyFromState’; did you mean ‘CopyToState’?
87 | void (*CopyFromStart) (CopyFromState cstate, TupleDesc tupDesc);
| ^~~~~~~~~~~~~
| CopyToState
/pgsql/source/master/src/include/commands/copyapi.h:98:44: error: unknown type name ‘CopyFromState’; did you mean ‘CopyToState’?
98 | bool (*CopyFromOneRow) (CopyFromState cstate, ExprContext *econtext,
| ^~~~~~~~~~~~~
| CopyToState
/pgsql/source/master/src/include/commands/copyapi.h:102:41: error: unknown type name ‘CopyFromState’; did you mean ‘CopyToState’?
102 | void (*CopyFromEnd) (CopyFromState cstate);
| ^~~~~~~~~~~~~
| CopyToState
/pgsql/source/master/src/include/commands/copyapi.h:103:1: warning: no semicolon at end of struct or union
103 | } CopyFromRoutine;
| ^

I think the fix should be the attached.

--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
"In Europe they call me Niklaus Wirth; in the US they call me Nickel's worth.
That's because in Europe they call me by name, and in the US by value!"

Attachment Content-Type Size
copy-headersfix.patch text/x-diff 2.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alexander Kukushkin 2024-11-21 10:42:13 Re: pg_rewind WAL segments deletion pitfall
Previous Message vignesh C 2024-11-21 09:55:19 Re: Disallow UPDATE/DELETE on table with unpublished generated column as REPLICA IDENTITY