| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Maxim Orlov <orlovmg(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Test 041_checkpoint_at_promote.pl faild in installcheck due to missing injection_points |
| Date: | 2024-08-20 16:30:35 |
| Message-ID: | 202408201630.mn6vbohjh7hh@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2024-Aug-20, Tom Lane wrote:
> We do, however, need to preserve the property that installcheck
> works after install-world. I'm starting to think that maybe
> the 041 test should be hacked to silently skip if it doesn't
> find injection_points available.
Yeah, I like this option. Injection points require to be explicitly
enabled in configure, so skipping that test when injection_points can't
be found seems reasonable.
This also suggests that EXTRA_INSTALL should have injection_points only
when the option is enabled.
I've been curious about what exactly does this Makefile line
export enable_injection_points enable_injection_points
achieve.
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David G. Johnston | 2024-08-20 16:42:05 | Re: Add new protocol message to change GUCs for usage with future protocol-only GUCs |
| Previous Message | Melih Mutlu | 2024-08-20 16:29:21 | Re: ANALYZE ONLY |