Re: Drop database command will raise "wrong tuple length" if pg_database tuple contains toast attribute.

On Mon, 19 Aug 2024 00:35:39 +0200
Tomas Vondra <tomas(at)vondra(dot)me> wrote:

> On 8/16/24 13:26, Tomas Vondra wrote:
> > Hi Ayush,
> >
> > ...
> >
> > So this fix seems reasonable.
> >
>
> I've pushed this to all affected branches, except for 11 which is EOL.
>
> I thought about adding a test, but I couldn't think of a TAP test where
> this would really fit, and it didn't seem very practical to have a test
> creating hundreds of roles. So I abandoned the idea.

I tried to add Assert in heap_inplace_update to prevent possible similar
failures, but I gave up because I could not find a good way to determine if
a tuple is detoasted of not.

By the way, I found a comment in vac_update_datfrozenxid() and EventTriggerOnLogin()
that explains why we could not use tuples from the syscache for heap_inplace_update.
I think it is better ad d the same comment in dropdb(). I attached a trivial patch for it.

Regards,
Yugo Nagata

--
Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp>