From: | Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp> |
---|---|
To: | Tomas Vondra <tomas(at)vondra(dot)me> |
Cc: | Ayush Tiwari <ayushtiwari(dot)slg01(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Drop database command will raise "wrong tuple length" if pg_database tuple contains toast attribute. |
Date: | 2024-08-19 09:01:54 |
Message-ID: | 20240819180154.20250e3ebc21b0aca7a25764@sraoss.co.jp |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Mon, 19 Aug 2024 00:35:39 +0200
Tomas Vondra <tomas(at)vondra(dot)me> wrote:
> On 8/16/24 13:26, Tomas Vondra wrote:
> > Hi Ayush,
> >
> > ...
> >
> > So this fix seems reasonable.
> >
>
> I've pushed this to all affected branches, except for 11 which is EOL.
>
> I thought about adding a test, but I couldn't think of a TAP test where
> this would really fit, and it didn't seem very practical to have a test
> creating hundreds of roles. So I abandoned the idea.
I tried to add Assert in heap_inplace_update to prevent possible similar
failures, but I gave up because I could not find a good way to determine if
a tuple is detoasted of not.
By the way, I found a comment in vac_update_datfrozenxid() and EventTriggerOnLogin()
that explains why we could not use tuples from the syscache for heap_inplace_update.
I think it is better ad d the same comment in dropdb(). I attached a trivial patch for it.
Regards,
Yugo Nagata
--
Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp>
Attachment | Content-Type | Size |
---|---|---|
improve_comment_on_dropdb.patch | text/x-diff | 602 bytes |
From | Date | Subject | |
---|---|---|---|
Next Message | Jelte Fennema-Nio | 2024-08-19 09:04:19 | Re: gitmaster server problem? |
Previous Message | Andrei Lepikhov | 2024-08-19 08:43:35 | Re: Asymmetric partition-wise JOIN |