| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Erik Rijkers <er(at)xs4all(dot)nl>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Subject: | Re: gcc 12.1.0 warning |
| Date: | 2024-07-15 16:41:55 |
| Message-ID: | 20240715164155.7blp2h6j4spc2ha4@awork3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2024-05-10 12:13:21 +0300, Nazir Bilal Yavuz wrote:
> On Tue, 23 Apr 2024 at 19:59, Andres Freund <andres(at)anarazel(dot)de> wrote:
> >
> >
> > Which seems entirely legitimate. ISTM that guc_var_compare() ought to only
> > cast the pointers to the key type, i.e. char *. And incidentally that does
> > prevent the warning.
> >
> > The reason it doesn't happen in newer versions of postgres is that we aren't
> > using guc_var_compare() in the relevant places anymore...
>
> The fix is attached. It cleanly applies from REL_15_STABLE to
> REL_12_STABLE, fixes the warnings and the tests pass.
Thanks! I've applied it to all branches - while it's not required to avoid a
warning in newer versions, it's still not correct as it was...
Greetings,
Andres
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stepan Neretin | 2024-07-15 16:42:08 | Re: Sort functions with specialized comparators |
| Previous Message | Nathan Bossart | 2024-07-15 15:31:08 | Re: Remove dependence on integer wrapping |