Re: ci: Build standalone INSTALL file

From: Andres Freund <andres(at)anarazel(dot)de>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Subject: Re: ci: Build standalone INSTALL file
Date: 2023-12-21 09:17:57
Message-ID: 20231221091757.difddgbds2mng25r@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 2023-12-21 08:39:26 +0900, Michael Paquier wrote:
> On Wed, Dec 20, 2023 at 11:36:28AM -0500, Tom Lane wrote:
> > Andres Freund <andres(at)anarazel(dot)de> writes:
> >> We fairly regularly have commits breaking the generation of INSTALL. IIRC we
> >> recently discussed building it locally unconditionally, but I couldn't
> >> immediately find that discussion. Until then, I think we should at least
> >> build it in CI so that cfbot can warn.
> >
> > I thought the plan was to get rid of that file, in pursuit of making
> > our distribution tarballs be more or less pure git pulls. Instead of
> > expending more effort on it, why not just push that project forward?
> > (IIRC, what we intended to do instead was to modify the top-level
> > README to point at the HTML install directions on the web.)

Ah, right. I don't really care what solution we go for, just that as long as
we have INSTALL, we should make sure we don't regularly break it... Both
Michael and I have in the last couple weeks.

> Hmm. It depends on if the next release should include it or not, but
> let me add my +1 for replacing it with a simple redirect.

Are you going to submit a patch for that bit?

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2023-12-21 09:29:41 Re: Function to get invalidation cause of a replication slot.
Previous Message Andres Freund 2023-12-21 09:16:23 Re: ci: Build standalone INSTALL file