Re: Using defines for protocol characters

From: Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp>
To: nathandbossart(at)gmail(dot)com
Cc: alvherre(at)alvh(dot)no-ip(dot)org, davecramer(at)gmail(dot)com, tgl(at)sss(dot)pgh(dot)pa(dot)us, peter(at)eisentraut(dot)org, robertmhaas(at)gmail(dot)com, smithpb2250(at)gmail(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Using defines for protocol characters
Date: 2023-08-15 21:25:09
Message-ID: 20230816.062509.1470544038131058557.t-ishii@sranhm.sra.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On Tue, Aug 15, 2023 at 02:46:24PM +0900, Tatsuo Ishii wrote:
>> Is it possible to put the new define staff into protocol.h then let
>> pqcomm.h include protocol.h? This makes Pgpool-II and other middle
>> ware/drivers written in C easier to use the defines so that they only
>> include protocol.h to use the defines.
>
> It is possible, of course, but are there any reasons such programs couldn't
> include pqcomm.h? It looks relatively inexpensive to me. That being said,
> I'm fine with the approach you describe if the folks in this thread agree.

Currently pqcomm.h needs c.h which is not problem for Pgpool-II. But
what about other middleware?

Best reagards,
--
Tatsuo Ishii
SRA OSS LLC
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2023-08-15 21:37:18 Re: Using defines for protocol characters
Previous Message Nathan Bossart 2023-08-15 20:31:09 Re: run pgindent on a regular basis / scripted manner