Re: Using defines for protocol characters

From: Nathan Bossart <nathandbossart(at)gmail(dot)com>
To: Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp>
Cc: alvherre(at)alvh(dot)no-ip(dot)org, davecramer(at)gmail(dot)com, tgl(at)sss(dot)pgh(dot)pa(dot)us, peter(at)eisentraut(dot)org, robertmhaas(at)gmail(dot)com, smithpb2250(at)gmail(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Using defines for protocol characters
Date: 2023-08-15 15:58:02
Message-ID: 20230815155802.GA2298234@nathanxps13
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Aug 15, 2023 at 02:46:24PM +0900, Tatsuo Ishii wrote:
> Is it possible to put the new define staff into protocol.h then let
> pqcomm.h include protocol.h? This makes Pgpool-II and other middle
> ware/drivers written in C easier to use the defines so that they only
> include protocol.h to use the defines.

It is possible, of course, but are there any reasons such programs couldn't
include pqcomm.h? It looks relatively inexpensive to me. That being said,
I'm fine with the approach you describe if the folks in this thread agree.

--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2023-08-15 16:11:38 Re: Extending SMgrRelation lifetimes
Previous Message Nathan Bossart 2023-08-15 15:42:08 Re: [PATCH] Add function to_oct