Re: pgsql: Allow logical decoding on standbys

At Wed, 12 Apr 2023 11:10:00 -0700, Andres Freund <andres(at)anarazel(dot)de> wrote in
> Hi,
>
> On 2023-04-12 10:42:44 -0700, Andres Freund wrote:
> > On 2023-04-11 12:02:53 +0900, Kyotaro Horiguchi wrote:
> > > > Allow logical decoding on standbys
> > >
> > > This adds the following error message.
> > >
> > > + errmsg("logical decoding on a standby requires wal_level to be at least logical on the primary")));
> > >
> > > We alredy have a nearly identical message as follows.
> > >
> > > > errmsg("logical decoding requires wal_level >= logical")));
> > >
> > > And we used to writte this kind of conditions, like "wal_level >=
> > > logical", using a mathematical operator. Don't we need to unify them?
> >
> > I guess. It doesn't seem particularly important, but why not.
>
> If we do that, we should adjust the errdetail() that you (correctly!) pointed
> out as needing punctuation as well. Pushed those improvements together.

Thanks!

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center