From: | Andres Freund <andres(at)anarazel(dot)de> |
---|---|
To: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | Re: pgsql: Allow logical decoding on standbys |
Date: | 2023-04-12 18:10:00 |
Message-ID: | 20230412181000.sk67iouifwhnhhkh@awork3.anarazel.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Hi,
On 2023-04-12 10:42:44 -0700, Andres Freund wrote:
> On 2023-04-11 12:02:53 +0900, Kyotaro Horiguchi wrote:
> > > Allow logical decoding on standbys
> >
> > This adds the following error message.
> >
> > + errmsg("logical decoding on a standby requires wal_level to be at least logical on the primary")));
> >
> > We alredy have a nearly identical message as follows.
> >
> > > errmsg("logical decoding requires wal_level >= logical")));
> >
> > And we used to writte this kind of conditions, like "wal_level >=
> > logical", using a mathematical operator. Don't we need to unify them?
>
> I guess. It doesn't seem particularly important, but why not.
If we do that, we should adjust the errdetail() that you (correctly!) pointed
out as needing punctuation as well. Pushed those improvements together.
Greetings,
Andres Freund
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2023-04-12 18:10:02 | pgsql: Improve error messages introduced in be87200efd9 and 0fdab27ad68 |
Previous Message | Alvaro Herrera | 2023-04-12 17:44:38 | pgsql: Revert "Catalog NOT NULL constraints" and fallout |