| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, Jeff Davis <pgsql(at)j-davis(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com>, Amit Khandekar <amitdkhan(dot)pg(at)gmail(dot)com>, fabriziomello(at)gmail(dot)com, tushar <tushar(dot)ahuja(at)enterprisedb(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Melanie Plageman <melanieplageman(at)gmail(dot)com> |
| Subject: | Re: Minimal logical decoding on standbys |
| Date: | 2023-04-04 17:53:38 |
| Message-ID: | 20230404175338.4ljhs7tc3jfsrdgx@awork3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2023-04-04 18:54:33 +0200, Drouvot, Bertrand wrote:
> if (check_on_xid)
> {
> if (terminating)
> appendStringInfo(&err_msg, _("terminating process %d to release replication slot \"%s\" because it conflicts with recovery"),
> pid,
> NameStr(slotname));
FWIW, I would just use exactly the same error message as today here.
errmsg("terminating process %d to release replication slot \"%s\"",
active_pid, NameStr(slotname)),
This is accurate for both the existing and the new case. Then there's no need
to put that string into a stringinfo either.
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2023-04-04 17:55:17 | Re: proposal: psql: show current user in prompt |
| Previous Message | Melanie Plageman | 2023-04-04 17:53:15 | Re: Option to not use ringbuffer in VACUUM, using it in failsafe mode |