| From: | Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp> |
|---|---|
| To: | nagata(at)sraoss(dot)co(dot)jp, masao(dot)fujii(at)oss(dot)nttdata(dot)com, alvherre(at)alvh(dot)no-ip(dot)org, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: make_ctags: use -I option to ignore pg_node_attr macro |
| Date: | 2023-02-08 00:49:41 |
| Message-ID: | 20230208.094941.2180555944275888348.t-ishii@sranhm.sra.co.jp |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
>> I am not sure if this is good way to check if ctags supports "-e" or not.
>>
>> + then ctags --version 2>&1 | grep -- -e >/dev/null
>>
>> Perhaps, "--help" might be intended rather than "--version" to check
>> supported options?
>
> Yeah, that was my mistake.
>
>> Even so, ctags would have other option whose name contains
>> "-e" than Emacs support, so this check could end in a wrong result. Therefore,
>> it seems to me that it is better to check immediately if etags is available
>> in case that we don't have Exuberant-type ctags.
>
> That makes sense.
Attached is the v2 patch.
Best reagards,
--
Tatsuo Ishii
SRA OSS LLC
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
| Attachment | Content-Type | Size |
|---|---|---|
| fix-make_ctags-v2.patch | text/x-patch | 2.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stephen Frost | 2023-02-08 01:02:05 | Re: RLS makes COPY TO process child tables |
| Previous Message | Tatsuo Ishii | 2023-02-08 00:20:34 | Re: make_ctags: use -I option to ignore pg_node_attr macro |