Re: make_ctags: use -I option to ignore pg_node_attr macro

From: Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp>
To: nagata(at)sraoss(dot)co(dot)jp
Cc: masao(dot)fujii(at)oss(dot)nttdata(dot)com, alvherre(at)alvh(dot)no-ip(dot)org, pgsql-hackers(at)postgresql(dot)org
Subject: Re: make_ctags: use -I option to ignore pg_node_attr macro
Date: 2023-02-08 00:20:34
Message-ID: 20230208.092034.1819747511154080382.t-ishii@sranhm.sra.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

>> The patch drops support for "-n" option :-<
>>
>> Attached is the patch by fixing make_ctags (make_etags is not
>> touched).
>>
>> If Exuberant-type ctags is available, use it (not changed).
>> If Exuberant-type ctags is not available, try old ctags (not changed).
>> If the old ctags does not support "-e" option, try etags (new).
>
> I am not sure if this is good way to check if ctags supports "-e" or not.
>
> + then ctags --version 2>&1 | grep -- -e >/dev/null
>
> Perhaps, "--help" might be intended rather than "--version" to check
> supported options?

Yeah, that was my mistake.

> Even so, ctags would have other option whose name contains
> "-e" than Emacs support, so this check could end in a wrong result. Therefore,
> it seems to me that it is better to check immediately if etags is available
> in case that we don't have Exuberant-type ctags.

That makes sense.

Best reagards,
--
Tatsuo Ishii
SRA OSS LLC
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tatsuo Ishii 2023-02-08 00:49:41 Re: make_ctags: use -I option to ignore pg_node_attr macro
Previous Message Tom Lane 2023-02-07 23:33:45 Re: A bug in make_outerjoininfo