Re: Replace PROC_QUEUE / SHM_QUEUE with ilist.h

From: Andres Freund <andres(at)anarazel(dot)de>
To: pgsql-hackers(at)postgresql(dot)org
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Amit Langote <amitlangote09(at)gmail(dot)com>
Subject: Re: Replace PROC_QUEUE / SHM_QUEUE with ilist.h
Date: 2023-01-20 02:58:45
Message-ID: 20230120025845.zavnnjzsa3r2bp5f@awork3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 2022-12-03 10:17:22 -0800, Andres Freund wrote:
> On 2022-11-19 21:59:30 -0800, Andres Freund wrote:
> > In [1] Robert justifiably complained about the use of PROC_QUEUE. I've
> > previously been bothered by this in [2], but didn't get around to finishing
> > the patches.
> >
> > One thing that made me hesitate was the naming of the function for a) checking
> > whether a dlist_node is a list, b) initializing and deleting nodes in a way to
> > allow for a). My patch adds dlist_node_init(), dlist_delete_thoroughly() /
> > dlist_delete_from_thoroughly() / dclist_delete_from_thoroughly() and
> > dlist_node_is_detached(). Thomas proposed dlist_delete_and_reinit() and
> > dlist_node_is_linked() instead.
>
> Any comments on these names? Otherwise I'm planning to push ahead with the
> names as is, lest I forget this patchset for another ~2 years.

Finally pushed, with some fairly minor additional cleanup. No more SHM_QUEUE,
yay!

Also, predicate.c really needs some love.

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Langote 2023-01-20 03:13:53 Re: generic plans and "initial" pruning
Previous Message torikoshia 2023-01-20 02:43:51 Re: Record queryid when auto_explain.log_verbose is on