| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Amit Langote <amitlangote09(at)gmail(dot)com> |
| Subject: | Re: Replace PROC_QUEUE / SHM_QUEUE with ilist.h |
| Date: | 2022-12-03 18:17:22 |
| Message-ID: | 20221203181722.ib6fwzuorhktpmhz@awork3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2022-11-19 21:59:30 -0800, Andres Freund wrote:
> In [1] Robert justifiably complained about the use of PROC_QUEUE. I've
> previously been bothered by this in [2], but didn't get around to finishing
> the patches.
>
> One thing that made me hesitate was the naming of the function for a) checking
> whether a dlist_node is a list, b) initializing and deleting nodes in a way to
> allow for a). My patch adds dlist_node_init(), dlist_delete_thoroughly() /
> dlist_delete_from_thoroughly() / dclist_delete_from_thoroughly() and
> dlist_node_is_detached(). Thomas proposed dlist_delete_and_reinit() and
> dlist_node_is_linked() instead.
Any comments on these names? Otherwise I'm planning to push ahead with the
names as is, lest I forget this patchset for another ~2 years.
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2022-12-03 19:20:35 | Re: Questions regarding distinct operation implementation |
| Previous Message | Andrey Borodin | 2022-12-03 17:41:04 | Re: Transaction timeout |