| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Richard Guo <guofenglinux(at)gmail(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Crash after a call to pg_backup_start() |
| Date: | 2022-10-22 07:56:06 |
| Message-ID: | 20221022075606.nh535vg447js2vic@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2022-Oct-21, Michael Paquier wrote:
> On Fri, Oct 21, 2022 at 05:53:25PM +0800, Richard Guo wrote:
> > /* These conditions can not be both true */
>
> If you do that, it would be a bit easier to read as of the following
> assertion instead? Like:
> Assert(!during_backup_start ||
> sessionBackupState == SESSION_BACKUP_NONE);
My intention here was that the Assert should be inside the block, that
is, we already know that at least one is true, and we want to make sure
that they are not *both* true.
AFAICT the attached patch also fixes the bug without making the assert
weaker.
--
Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Fix-misplaced-assertion.patch | text/x-diff | 1.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2022-10-22 08:00:36 | Re: Missing update of all_hasnulls in BRIN opclasses |
| Previous Message | Zhang Mingli | 2022-10-22 03:32:47 | doubt about FullTransactionIdAdvance() |