From 710eef9259f4286f8d8660ac1dd898323205a037 Mon Sep 17 00:00:00 2001 From: Alvaro Herrera Date: Sat, 22 Oct 2022 09:54:24 +0200 Subject: [PATCH] Fix misplaced assertion --- src/backend/access/transam/xlog.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c index dea978a962..fb3fbcd2be 100644 --- a/src/backend/access/transam/xlog.c +++ b/src/backend/access/transam/xlog.c @@ -8841,12 +8841,12 @@ do_pg_abort_backup(int code, Datum arg) { bool during_backup_start = DatumGetBool(arg); - /* Only one of these conditions can be true */ - Assert(during_backup_start ^ - (sessionBackupState == SESSION_BACKUP_RUNNING)); - if (during_backup_start || sessionBackupState != SESSION_BACKUP_NONE) { + /* We should be here only by one of these reasons, never both */ + Assert(during_backup_start ^ + (sessionBackupState == SESSION_BACKUP_RUNNING)); + WALInsertLockAcquireExclusive(); Assert(XLogCtl->Insert.runningBackups > 0); XLogCtl->Insert.runningBackups--; -- 2.30.2