| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | interrupted tap tests leave postgres instances around |
| Date: | 2022-09-30 04:07:34 |
| Message-ID: | 20220930040734.mbted42oiynhn2t6@awork3.anarazel.de |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
When tap tests are interrupted (e.g. with ctrl-c), we don't cancel running
postgres instances etc. That doesn't strike me as a good thing.
In contrast, the postgres instances started by pg_regress do terminate. I
assume this is because pg_regress starts postgres directly, whereas tap tests
largely start postgres via pg_ctl. pg_ctl will, as it should, start postgres
without a controlling terminal. Thus a ctrl-c won't be delivered to it.
ISTM we should at least install a SIGINT/TERM handler in Cluster.pm that does
the stuff we already do in END.
That still leaves us with some other potential processes around that won't
immediately exec, but it'd be much better already.
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2022-09-30 04:17:41 | Re: longfin and tamandua aren't too happy but I'm not sure why |
| Previous Message | Thomas Munro | 2022-09-30 04:04:43 | Re: Suppressing useless wakeups in walreceiver |