Re: A doubt about a newly added errdetail

From: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
To: alvherre(at)alvh(dot)no-ip(dot)org
Cc: houzj(dot)fnst(at)fujitsu(dot)com, amit(dot)kapila16(at)gmail(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: A doubt about a newly added errdetail
Date: 2022-09-28 06:00:34
Message-ID: 20220928.150034.1325913962801104491.horikyota.ntt@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

At Tue, 27 Sep 2022 12:19:35 +0200, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote in
> Yeah, since you're changing another word in that line, it's ok to move
> the parameter line off-string. (If you were only changing the parameter
> to %s and there was no message duplication, I would reject the patch as
> useless.)

I'm fine with that. By the way, related to the area, I found the
following error messages.

> errmsg("publication \"%s\" is defined as FOR ALL TABLES",
> NameStr(pubform->pubname)),
> errdetail("Schemas cannot be added to or dropped from FOR ALL TABLES publications.")));

It looks tome that the errmsg and errordetail are reversed. Isn't the following order common?

> errmsg("schemas cannot be added to or dropped from publication \"%s\".",
> NameStr(pubform->pubname)),
> errdetail("The publication is defined as FOR ALL TABLES.")));

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2022-09-28 06:11:52 Re: Use pg_pwritev_with_retry() instead of write() in dir_open_for_write() to avoid partial writes?
Previous Message kuroda.hayato@fujitsu.com 2022-09-28 05:57:41 RE: [PATCH] Use indexes on the subscriber when REPLICA IDENTITY is full on the publisher