Re: A doubt about a newly added errdetail

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>
Cc: "amit(dot)kapila16(at)gmail(dot)com" <amit(dot)kapila16(at)gmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
Subject: Re: A doubt about a newly added errdetail
Date: 2022-09-27 10:19:35
Message-ID: 20220927101935.fwyvdia7yzaxwu7e@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2022-Sep-27, houzj(dot)fnst(at)fujitsu(dot)com wrote:

> Thanks for reviewing!
>
> Just in case I misunderstand, it seems you mean the message style[1] is OK, right ?
>
> [1]
> errdetail("Column list cannot be specified for a partitioned table when %s is false.",
> "publish_via_partition_root")));

Yeah, since you're changing another word in that line, it's ok to move
the parameter line off-string. (If you were only changing the parameter
to %s and there was no message duplication, I would reject the patch as
useless.)

I'm going over that patch now, I have a few other changes as attached,
intend to commit soon.

--
Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/
"Ni aún el genio muy grande llegaría muy lejos
si tuviera que sacarlo todo de su propio interior" (Goethe)

Attachment Content-Type Size
more.patch text/x-diff 3.5 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message 孤傲小二~阿沐 2022-09-27 10:23:25 Questions about the patch of Add ON CONFLICT DO RETURN clause
Previous Message Bharath Rupireddy 2022-09-27 09:53:04 Extend win32 error codes to errno mapping in win32error.c